Buffer comparison support #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughrawlinson
force-pushed
the
buffer-comparison-support
branch
from
fd3329e
to
83e0d8d
Compare
|
This is a great addition which will allow us to add more incredible features. As we can't really test it atm, let's wait with the merge until we have a feature that uses this functionality. Otherwise 👍 |
This was referenced Feb 10, 2016
Closed
* Max lines at 80 chars * Fixes some broken links in old comments * Adheres us to AirBnb's styleguide, which is widely used and good * Switches us from using jshint for linting to jscs
|
@nevosegal This branch now includes flux. I'd appreciate tests, any chance you could generate the spectral flux data for one of our buffers so that we can test this? I need to squash the commits and rebase onto master once my other PR is merged anyway, so don't merge this PR yet. By "other pr" I mean #123 |
hughrawlinson
force-pushed
the
buffer-comparison-support
branch
from
54961b1
to
bd4144d
Compare
added 2 commits
March 29, 2016 10:45
Adds support for comparing the current buffer (and associated data) with that of the previous frame.
We've wanted this for a long time. Fixes #30.
hughrawlinson
force-pushed
the
buffer-comparison-support
branch
from
bd4144d
to
3b3f33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or allows it to be passes, in the case of offline extraction. Paves the way for Flux!