Add SVGNodeContainer::setChild method

See #51.
meyfa · Mar 21, 2018 · 48c3980 · 48c3980
1 parent 9e50562
commit 48c3980
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 3 deletions.
diff --git a/src/Nodes/SVGNodeContainer.php b/src/Nodes/SVGNodeContainer.php
@@ -65,13 +65,13 @@ public function addChild(SVGNode $node, $index = null)
      * Removes a child node, given either as its instance or as the index it's
      * located at, from this container.
      *
-     * @param SVGNode|int $nodeOrIndex The node (or respective index) to remove.
+     * @param SVGNode|int $child The node (or respective index) to remove.
      *
      * @return $this This node instance, for call chaining.
      */
-    public function removeChild($nodeOrIndex)
+    public function removeChild($child)
     {
-        $index = $this->resolveChildIndex($nodeOrIndex);
+        $index = $this->resolveChildIndex($child);
         if ($index === false) {
             return $this;
         }
@@ -84,6 +84,27 @@ public function removeChild($nodeOrIndex)
         return $this;
     }
 
+    /**
+     * Replaces a child node with another node.
+     *
+     * @param SVGNode|int $child The node (or respective index) to replace.
+     * @param SVGNode     $node  The replacement node.
+     *
+     * @return $this This node instance, for call chaining.
+     */
+    public function setChild($child, SVGNode $node)
+    {
+        $index = $this->resolveChildIndex($child);
+        if ($index === false) {
+            return $this;
+        }
+
+        $this->removeChild($index);
+        $this->addChild($node, $index);
+
+        return $this;
+    }
+
     /**
      * Resolves a child node to its index. If an index is given, it is returned
      * without modification.

diff --git a/tests/Nodes/SVGNodeContainerTest.php b/tests/Nodes/SVGNodeContainerTest.php
@@ -85,6 +85,35 @@ public function testRemoveChild()
         $this->assertSame($obj, $obj->removeChild($child));
     }
 
+    public function testSetChild()
+    {
+        $obj = new SVGNodeContainerSubclass();
+        $obj2 = new SVGNodeContainerSubclass();
+
+        $child = new SVGNodeContainerSubclass();
+        $child2 = new SVGNodeContainerSubclass();
+
+        $obj->addChild($child);
+
+        // should replace by instance
+        $obj->setChild($child, $child2);
+        $this->assertSame(1, $obj->countChildren());
+        $this->assertSame($child2, $obj->getChild(0));
+
+        // should replace by index
+        $obj->setChild(0, $child);
+        $this->assertSame(1, $obj->countChildren());
+        $this->assertSame($child, $obj->getChild(0));
+
+        // should do nothing if instance does not exist
+        $obj->setChild(new SVGNodeContainerSubclass(), $child2);
+        $this->assertSame(1, $obj->countChildren());
+        $this->assertSame($child, $obj->getChild(0));
+
+        // should return same instance
+        $this->assertSame($obj, $obj->setChild(0, $child2));
+    }
+
     public function testRasterize()
     {
         $obj = new SVGNodeContainerSubclass();