chore: Remove TODO about PHP version 5.3 missing a parameter #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyfa
pushed a commit
that referenced
this pull request
Dec 11, 2022
* chore: update README, add newer PHP versions As discussed in #187 older versions were dropped and support for PHP 8.1 and 8.2 was added. Updated README to also mention newer versions. * chore: Updated readme, added new PHP versions After the previous commit (where a shield/badge was added), noticed README text also needed an updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109. We don't support PHP 5.3 anymore due to PR #182, so the TODO can safely be removed, along with the
@requireson associated tests.