refactor: Use ::class instead of FQN-strings
#212
Conversation
Change namespaces for test classes to comply with PSR-4. As per PSR-4 2.3.2 the namespace should follow the projects directory structure (https://www.php-fig.org/psr/psr-4/).
As of PHP 5.5 SomeClass::class represents SomeClass' FQN. As support for <7.3 (thus <5.5) was dropped in meyfa#182, this notation can now be used.
Niellles
force-pushed
the
feat/I-love-chores
branch
from
292462b
to
2100d46
Compare
|
I don't particularly care for the long list of use statements in |
|
Very nice, this is great! Would it be possible & acceptable to avoid all the imports in This should lead to some amount of type safety since it's possible to statically verify the class existence, instead of it being a string. I'm not sure, however, if this is possible in PHP and whether it would lead to IDEs complaining about the FQDN and suggesting to add the imports. |
|
Hey @Niellles, I hope you're doing well. Did you have time to look into my previous comment? If not that's alright as well, I might merge this PR as-is, then. WDYT? |
I prefer having the use statements, in fact I think some of the cleanup scripts (rector or php-cs, I forget which) will refactor them. |
|
@meyfa Doing great, thanks for asking :). I've been somewhat busy. Personally I prefer the use statements. However, I was thinking maybe the node types should be enums. Not that we can use PHPs native "real" enums (although we could if we fix #215).. can you take a look at: Niellles#2? |
meyfa
changed the title
::class instead of FQN-strings
|
@Niellles I don't know about the enum refactor. What's the benefit over the current design? |
|
Thanks for your work on this by the way, and sorry it has taken so long to get merged. |
|
Just published v0.15.0 including these changes 🎉 |
No description provided.