Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Leverage PHP 7.4 syntax #226

Merged
merged 3 commits into from
Mar 17, 2024
Merged

fix: Leverage PHP 7.4 syntax #226

merged 3 commits into from
Mar 17, 2024

Conversation

smnandre
Copy link
Contributor

No description provided.

@meyfa meyfa linked an issue Mar 17, 2024 that may be closed by this pull request
Drop unmaintained PHP, publish a release #215
Closed
meyfa
meyfa requested changes Mar 17, 2024
View reviewed changes
Copy link
Owner

@meyfa meyfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this effort, it's very much appreciated! I left some suggestions, could you have a look?

src/Nodes/Shapes/SVGPath.php Outdated Show resolved Hide resolved
src/Rasterization/Path/PathApproximator.php Show resolved Hide resolved
src/Rasterization/Path/PathApproximator.php Show resolved Hide resolved
src/Rasterization/Renderers/PathRendererEdge.php Show resolved Hide resolved
src/Reading/LengthAttributeConverter.php Outdated Show resolved Hide resolved
@meyfa meyfa changed the title [CS] Leverage PHP 7.4 fix: Leverage PHP 7.4 syntax Mar 17, 2024
@smnandre
Copy link
Contributor Author

Thanks for this effort, it's very much appreciated! I left some suggestions, could you have a look?

Will do tonight !

meyfa
meyfa approved these changes Mar 17, 2024
View reviewed changes
Copy link
Owner

@meyfa meyfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@meyfa meyfa merged commit 51251be into meyfa:main Mar 17, 2024
7 checks passed
@meyfa
Copy link
Owner

meyfa commented Mar 17, 2024

Just published v0.15.0 including these changes 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyfa meyfa meyfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop unmaintained PHP, publish a release
2 participants
@smnandre @meyfa