Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to try to run the whole project, and doing it using Docker, so here's my contribution on that topic 😉
DONE / Setup ✅
passenger
,booking
,flight
,identity
)compose.yaml
files.env
file, replacinglocalhost
by containers hostnamesTODO / Improvements 🚧
localhost
references inbooking-microservices-nestjs/src/booking/src/booking/http-client/services/passenger/passenger-client.ts
Line 17 in fb352ad
booking-microservices-nestjs/src/booking/src/booking/http-client/services/flight/flight.client.ts
Line 22 in fb352ad
compose.infrastructure.yaml
)compose.services.yaml
to be able to do live modifications ? (can then face issues withnode_modules
synchronization between host (files on disk, mounted by the volume mapping) and container (newly generated files, built via docker))