Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Use github.com/rsjethani/sysinfo package #4

Merged
merged 1 commit into from
Jan 13, 2019

Conversation

rsjethani
Copy link
Collaborator

Use this package to get information from the Kernel instead of external commands

Resolves: Issue #1

Use this package to get information from the Kernel instead of
external commands

Resolves: Issue meysampg#1
@meysampg meysampg merged commit 3949df8 into meysampg:master Jan 13, 2019
@meysampg
Copy link
Owner

@rsjethani
I love your attitude on the development of sysinfo package. Thanks!
❤️

@rsjethani
Copy link
Collaborator Author

@meysampg thank you :)
It's just a start hoping to make that project into something very useful.

@meysampg
Copy link
Owner

@rsjethani Can you add a vendor system like gomodule, dep or glide to the project?

@rsjethani
Copy link
Collaborator Author

@meysampg to sysinfo?

@meysampg
Copy link
Owner

@rsjethani to battery_notifier.

@rsjethani
Copy link
Collaborator Author

@meysampg ok sure will do. Also i think should remove -d and -n options. Its a small project so -d doesn't makes sense. And since we always intend to send notification -n is redundant.

@meysampg
Copy link
Owner

@rsjethani Thanks, dude.
-n is not redundant. I think there are situations which result from this utility will be used on shell scripting.

@rsjethani
Copy link
Collaborator Author

@meysampg if i run without any options, i do not get any output. Are you planning to add something to the project that will make it usable in shell script?

@meysampg
Copy link
Owner

@rsjethani I do, but currently, I'm very busy on my office and can't do that.
But you're right, it's annoying to use -n every time, so we can change this behavior, in the default manner if no -n is given, send a notification, otherwise send output to the CLI.
What's your opinion?

@rsjethani
Copy link
Collaborator Author

@meysampg if you are planning to use this in some script then let's keep -n explicitly for desktop notification i.e. the same behaviour as of now.

@meysampg
Copy link
Owner

@rsjethani If you think it's okay, it's okay 😉.

@rsjethani
Copy link
Collaborator Author

@meysampg you said you want to write a script around this. What exactly are you trying to achieve?

@meysampg
Copy link
Owner

@rsjethani to be honest, it's a vague imagination 😄.

@rsjethani
Copy link
Collaborator Author

rsjethani commented Jan 16, 2019

@meysampg this is what I want:
Continuously monitor battery status but only start notifying when battery percentage < threshold. And keep sending notification every few minutes. I will make a system service out of this.

I desired this functionality because current linux desktop environments do not send such notifications..many a times my laptop just powered down itself in the middle of a movie(no notifications or battery status in full screen) 😄

Next PR will complete this (my) requirement while keeping current functionality the way it is.

@meysampg
Copy link
Owner

@rsjethani The major purpose of this repository exactly was what you said 😄. i3wm doesn't send any notice on the low battery situations and for me, that was like drinking a cup of very cold coffee 😄.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants