-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created git-jira-pr. Added a Jira module to hold some common functionality. #50
Conversation
…ality. Standardized the branch naming to [PROJECT_KEY]-[ISSUE_ID]/[SUMMARY]
…g to github markdown. Not everything is handled yet.
require 'git-whistles/app' | ||
require 'git-whistles/jira' | ||
|
||
class App < Git::Whistles::App |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the consistency do you mind changing this file to only have 1 empty line inbetween methods?
Thanks @martyphee for this! Looks good. Hope my comments make sense. Also I think you might have to handle conflicts. |
I'm making the updates now. It was a bit of a rush. Thank you for the feedback. |
@pedrocunha I made the changes and have been using it the last few days. |
Sorry @martyphee for no feedback on this yet but do you mind solving the conflicts first please. Thanks. I'll try to review & merge this today. |
# Conflicts: # bin/git-jira-branch
Done, thx. On Tue, Feb 9, 2016 at 12:22 PM, Pedro Cunha notifications@github.com
|
|
||
def option_parser | ||
@option_parser ||= OptionParser.new do |op| | ||
op.banner = "Usage: git pivotal-pr [options]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here is jira-pr
?
Created git-jira-pr. Added a Jira module to hold some common functionality.
Cheers @martyphee |
Standardized the branch naming to [PROJECT_KEY]-[ISSUE_ID]/[SUMMARY]