Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created git-jira-pr. Added a Jira module to hold some common functionality. #50

Merged
merged 7 commits into from
Feb 10, 2016

Conversation

martyphee
Copy link
Contributor

Standardized the branch naming to [PROJECT_KEY]-[ISSUE_ID]/[SUMMARY]

…ality.

Standardized the branch naming to [PROJECT_KEY]-[ISSUE_ID]/[SUMMARY]
…g to github markdown. Not everything is handled yet.
require 'git-whistles/app'
require 'git-whistles/jira'

class App < Git::Whistles::App
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the consistency do you mind changing this file to only have 1 empty line inbetween methods?

@pedrocunha
Copy link
Collaborator

Thanks @martyphee for this! Looks good. Hope my comments make sense. Also I think you might have to handle conflicts.

@martyphee
Copy link
Contributor Author

I'm making the updates now. It was a bit of a rush. Thank you for the feedback.

@martyphee
Copy link
Contributor Author

@pedrocunha I made the changes and have been using it the last few days.

@pedrocunha
Copy link
Collaborator

Sorry @martyphee for no feedback on this yet but do you mind solving the conflicts first please. Thanks. I'll try to review & merge this today.

@martyphee
Copy link
Contributor Author

Done, thx.

On Tue, Feb 9, 2016 at 12:22 PM, Pedro Cunha notifications@github.com
wrote:

Sorry @martyphee https://github.com/martyphee for no feedback on this
yet but do you mind solving the conflicts first please. Thanks. I'll try to
review & merge this today.


Reply to this email directly or view it on GitHub
#50 (comment).


def option_parser
@option_parser ||= OptionParser.new do |op|
op.banner = "Usage: git pivotal-pr [options]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here is jira-pr ?

pedrocunha added a commit that referenced this pull request Feb 10, 2016
Created git-jira-pr.  Added a Jira module to hold some common functionality.
@pedrocunha pedrocunha merged commit 6794b9d into mezis:master Feb 10, 2016
@pedrocunha
Copy link
Collaborator

Cheers @martyphee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants