Expose flatpickr object #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to manually control flatpickr instance in some situations. since the flatpickr object is private in your wrapper component I added some methods to expose a couple methods from flatpickr.
|
Hi, thanks for the PR! Unfortunately this is not a good way to handle this issue, because eventually this will lead to duplicating all the flatpickr methods in the component, which is way too much code and requires too much mainteance. Making the flatpickr object public is way more easier and more maintainable. |
|
Updated the PR. Thanks! |
|
@mezoistvan ping |
|
Thanks! |
|
Released in v7.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to manually control flatpickr instance in some situations. since the flatpickr object is private in your wrapper component I added some methods to expose a couple methods from flatpickr.