Integrity validations #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation is scoped to module_result_id. The unit test for ModuleResult chidren association touches the database so fixes to the factories with proper id setting was necessary. Signed off by: Heitor Reis <marcheing@gmail.com>
The validation is scoped to the Processing which is gotten through its ModuleResult. That's why we need a custom validator. Signed off by: Heitor Reis <marcheing@gmail.com>
Now, with the new kalibro module validation, the validator needs the kalibro module to already have an association with a module result. The parsers for analizo, metric fu and radon were updated with this requirement. Signed off by: Rafael Reggiani Manzo <rr.manzo@gmail.com>
This validation broke HotspotMetricResults for which is valid results within the same ModuleResult. Take duplicate code within the same class.
The creation of KalibroModule requires a ModuleResult which was created only later on.
This validation avoid errors on LongNameValidator.
|
Nice job, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validations that may avoid errors within parsers.
This closes #133