Skip to content

Commit

Permalink
Fix improper property use causing invalid dependency POM (#2854)
Browse files Browse the repository at this point in the history
The archivesName property of BasePluginExtension is a Property<String>.
The default implementation of toString() for a Property is to print out
their name and owning object, and not the toString() of their contents.

This meant that passing archivesName to Node#appendNode as a value,
which calls toString() on it to make it into a String, results in e.g.
`extension 'base' property 'archivesName'` instead of the expected
value of e.g. `jei-1.19-common-api`.

The simple fix is to call Property#get() on archivesName to get its
actual value and pass that on as the node value.
  • Loading branch information
sciwhiz12 committed Jun 16, 2022
1 parent edc5e7c commit ad7fd38
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion FabricApi/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ publishing {
dependencyProjects.forEach {
val dependencyNode = dependenciesNode.appendNode("dependency")
dependencyNode.appendNode("groupId", it.group)
dependencyNode.appendNode("artifactId", it.base.archivesName)
dependencyNode.appendNode("artifactId", it.base.archivesName.get())
dependencyNode.appendNode("version", it.version)
}
}
Expand Down
2 changes: 1 addition & 1 deletion Forge/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ publishing {
dependencyProjects.forEach {
val dependencyNode = dependenciesNode.appendNode("dependency")
dependencyNode.appendNode("groupId", it.group)
dependencyNode.appendNode("artifactId", it.base.archivesName)
dependencyNode.appendNode("artifactId", it.base.archivesName.get())
dependencyNode.appendNode("version", it.version)
}
}
Expand Down
2 changes: 1 addition & 1 deletion ForgeApi/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ publishing {
dependencyProjects.forEach {
val dependencyNode = dependenciesNode.appendNode("dependency")
dependencyNode.appendNode("groupId", it.group)
dependencyNode.appendNode("artifactId", it.base.archivesName)
dependencyNode.appendNode("artifactId", it.base.archivesName.get())
dependencyNode.appendNode("version", it.version)
}
}
Expand Down

0 comments on commit ad7fd38

Please sign in to comment.