Skip to content

Commit

Permalink
Reduce memory used by an adversarial PacketRecipeTransfer
Browse files Browse the repository at this point in the history
  • Loading branch information
mezz committed Nov 15, 2022
1 parent 9992840 commit f128c3b
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ public static CompletableFuture<Void> readPacketData(ServerPacketData data) {
AbstractContainerMenu container = player.containerMenu;

int transferOperationsSize = buf.readVarInt();
List<TransferOperation> transferOperations = new ArrayList<>(transferOperationsSize);
List<TransferOperation> transferOperations = new ArrayList<>();
for (int i = 0; i < transferOperationsSize; i++) {
TransferOperation transferOperation = TransferOperation.readPacketData(buf, container);
transferOperations.add(transferOperation);
}

int craftingSlotsSize = buf.readVarInt();
List<Slot> craftingSlots = new ArrayList<>(craftingSlotsSize);
List<Slot> craftingSlots = new ArrayList<>();
for (int i = 0; i < craftingSlotsSize; i++) {
int slotIndex = buf.readVarInt();
Slot slot = container.getSlot(slotIndex);
Expand Down

0 comments on commit f128c3b

Please sign in to comment.