Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 Support #4

Merged
merged 2 commits into from
Oct 12, 2020
Merged

PHP 8.0 Support #4

merged 2 commits into from
Oct 12, 2020

Conversation

diwms
Copy link
Contributor

@diwms diwms commented Oct 6, 2020

Hi there 👋🏻
I'm trying to contribute and close issue #2

I've no idea what I need to write in the issue template since this is an attempt to close the existing issue 😄

Please, let me know what do you think guys 👍🏻

Happy Hacktoberfest! 🥇

weierophinney
weierophinney requested changes Oct 6, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@geerteltink
Copy link
Contributor

geerteltink commented Oct 7, 2020 •
edited
Loading

@diwms Can you please start with a good short description for your commit. Instead of this:

trying to close #2 …
PHP8 support!

... do it the other way around:

Add PHP 8 support

Fixes #2

Ocramius
Ocramius requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

.travis.yml Outdated Show resolved Hide resolved
@Ocramius Ocramius mentioned this pull request Oct 7, 2020
Merged
@diwms
Add PHP8 support
a64384f 
Fixes #2

Signed-off-by: Myroslav Zozulia <admin@diwms.com>
geerteltink
geerteltink reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@geerteltink geerteltink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple phpunit warnings about Method ReflectionParameter::getClass() is deprecated.

@diwms
Add explicitly prophecy dependency with php8 fixes
4bd51ab 
Signed-off-by: Myroslav Zozulia <admin@diwms.com>
Ocramius
Ocramius approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @diwms! Let's continue #3 now

@Ocramius Ocramius merged commit 3e420e2 into mezzio:1.1.x Oct 12, 2020
@Ocramius Ocramius added Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 12, 2020
@Ocramius Ocramius added this to the 1.1.0 milestone Oct 12, 2020
@Ocramius Ocramius self-assigned this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@weierophinney weierophinney Awaiting requested review from weierophinney

@geerteltink geerteltink Awaiting requested review from geerteltink

Assignees

@Ocramius Ocramius

Labels
Enhancement New feature or request hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diwms @geerteltink @weierophinney @Ocramius