Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow latest psr/* dependencies #43

Merged
merged 4 commits into from Jan 11, 2022
Merged

Allow latest psr/* dependencies #43

merged 4 commits into from Jan 11, 2022

Conversation

geerteltink
Copy link
Contributor

This PR allow latest psr dependencies.

@geerteltink geerteltink added this to the 2.3.0 milestone Jan 6, 2022
@geerteltink geerteltink added the Enhancement New feature or request label Jan 6, 2022
@geerteltink
Copy link
Contributor Author

@lcobucci do you have an idea why this is failing for php 8.0 with lowest dependencies only?

1) MezzioTest\Authentication\OAuth2\Pdo\OAuth2PdoMiddlewareTest::testProcessClientCredentialGrantConfidential
Lcobucci\JWT\Signer\InvalidKeyProvided: It was not possible to parse your key, reason: error:0909006C:PEM routines:get_name:no start line

@lcobucci
Copy link
Member

lcobucci commented Jan 7, 2022

@lcobucci do you have an idea why this is failing for php 8.0 with lowest dependencies only?

1) MezzioTest\Authentication\OAuth2\Pdo\OAuth2PdoMiddlewareTest::testProcessClientCredentialGrantConfidential
Lcobucci\JWT\Signer\InvalidKeyProvided: It was not possible to parse your key, reason: error:0909006C:PEM routines:get_name:no start line

I'll have a look. OpenSSL usually gives that error when the key is empty or something like that.

I also see that composer is installing v3.4.6 when running PHP 8.0, which shouldn't be possible as it isn't compatible with that version: https://packagist.org/packages/lcobucci/jwt#3.4.6

@geerteltink
Copy link
Contributor Author

Interesting:

Received job: {"command":"./vendor/bin/phpunit","php":"8.0","extensions":["pdo-sqlite"],"ini":["memory_limit        = -1"],"dependencies":"lowest","ignore_platform_reqs_8":true,"ignore_php_platform_requirement":true,"additional_composer_arguments":[]}

Where is that config coming from?

@Ocramius
Copy link
Member

Ocramius commented Jan 7, 2022

@froschdesign do we need to fix markdownlint before merging here? Seems like it wasn't run at all before 🤔

@geerteltink
Copy link
Contributor Author

@Ocramius It has to be fixed anyway. I'll try to do it today.

@lcobucci lcobucci mentioned this pull request Jan 10, 2022
Signed-off-by: Geert Eltink <geert.eltink@gmail.com>
Signed-off-by: Geert Eltink <geert.eltink@gmail.com>
Signed-off-by: Geert Eltink <geert.eltink@gmail.com>
Signed-off-by: Geert Eltink <geert.eltink@gmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geerteltink!

@Ocramius Ocramius self-assigned this Jan 11, 2022
@Ocramius Ocramius changed the title Allow latest psr/* dependencies Allow latest psr/* dependencies Jan 11, 2022
@Ocramius Ocramius merged commit e24d409 into mezzio:2.3.x Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants