Fix build issues #44
Merged
Fix build issues #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of running `composer update --lock` to avoid having composer complaining about outdated lockfile. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
These files are there for legacy purposes only and are just redirecting users. They don't need to be validated. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
fix-markdown-issues
branch
from
b474116
to
b1f3ef6
Compare
geerteltink
approved these changes
Jan 10, 2022
Ocramius
approved these changes
Jan 10, 2022
froschdesign
requested changes
Jan 11, 2022
Making sure we follow the rule `MD025/single-title/single-h1`. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
fix-markdown-issues
branch
from
47ed183
to
a589d8d
Compare
|
@froschdesign I dropped the commits that changed the rules you rejected. After reviewing the failures on #43 it's quite likely that I was wrong and mixed up the reported issues on my local env and CI. |
Yeah... I was wrong. Sorry about the confusion 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes sure our documentation is compatible with markdownlint rules so that #43 can focus on the right stuff.