Move "dflydev/fig-cookies" package to require-dev #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rieschl
changed the title
dflydev/fig-cookies is only used in test code. Having it in the production dependencies causes a conflict in consuming packages if they want to use v3 of dflydev/fig-cookies. also, allow version 3.0 of dflydev/fig-cookies Signed-off-by: Thomas Rieschl <thomas@trinet.at>
rieschl
force-pushed
the
move-fig-cookies
branch
from
ece28f8
to
1779eb8
Compare
Sorry, I thought, removing an unused dependency can be in a patch release. I rebased the commit to target |
|
Is it allowed to fix the whitespace bubu in this PR or should that be done separately? |
|
@Ocramius is there anything that I should do before it can be merged? thanks! |
froschdesign
approved these changes
Apr 8, 2021
|
@rieschl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dflydev/fig-cookies is only used in test code. Having it in the production dependencies causes a conflict in consuming packages if they want to use v3 of dflydev/fig-cookies.
also, allow version 3.0 of dflydev/fig-cookies
fixes #19