Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock file maintenance #85

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Lock file maintenance #85

merged 2 commits into from
Oct 25, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 28, 2022

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 2am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

Read more information about the use of Renovate Bot within Laminas.

@renovate renovate bot added the renovate label Sep 28, 2022
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from d33ea46 to 4125881 Compare October 17, 2022 07:36
@Ocramius
Copy link
Member

config.platform missing here leads to this tooling not really working here.

/cc @internalsystemerror can we perhaps configure the version directly in the renovate config?

@internalsystemerror
Copy link
Member

internalsystemerror commented Oct 17, 2022

@Ocramius Ah good idea! Yes then we could have our cake and eat it. I don't remember it off the top of my head though so I'd need to look into it again and I'm really overworked atm.

I believe it would be this option: https://docs.renovatebot.com/configuration-options/#constraints

@Ocramius
Copy link
Member

No worries - good to know that we can do this.

Not expecting you to, just using your pre-trained brain on these questions/problems :P

@Ocramius
Copy link
Member

Hmm, I think #87 didn't work here 🤔

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 409f1bd to 4f6eabd Compare October 25, 2022 15:09
@internalsystemerror
Copy link
Member

damn @Ocramius you are faster than light itself!

🤔 I'll see what the logs say, we might need to wrap the constraint in a "force": {}

@internalsystemerror
Copy link
Member

The constraint is working but its running update with --ignore-platform-reqs.

From https://app.renovatebot.com/dashboard#github/mezzio/mezzio-skeleton/863849589

DEBUG: Using php constraint from config(branch="renovate/lock-file-maintenance")
DEBUG: composer command(branch="renovate/lock-file-maintenance")
{
"cmd": "composer",
"args": "update --ignore-platform-reqs --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins"
}
DEBUG: Setting CONTAINERBASE_CACHE_DIR to /tmp/containerbase(branch="renovate/lock-file-maintenance")
DEBUG: Using docker to execute(branch="renovate/lock-file-maintenance")
{
"image": "php"
}
DEBUG: Resolved stable matching version(branch="renovate/lock-file-maintenance")
{
"toolName": "composer",
"constraint": "^1.5 || ^2.0",
"resolvedVersion": "2.4.3"
}
DEBUG: containerbaseDir is separate from cacheDir(branch="renovate/lock-file-maintenance")
DEBUG: Found version constraint - checking for a compatible image to use(branch="renovate/lock-file-maintenance")
{
"depName": "docker.io/renovate/php",
"scheme": "composer",
"constraint": "^7.4"
}
DEBUG: Found compatible image version(branch="renovate/lock-file-maintenance")
{
"depName": "docker.io/renovate/php",
"scheme": "composer",
"constraint": "^7.4",
"version": "7.4.32"
}
DEBUG: Resolved tag constraint(branch="renovate/lock-file-maintenance")
{
"image": "docker.io/renovate/php",
"tagConstraint": "^7.4",
"tagVersioning": "composer",
"tag": "7.4.32"
}
DEBUG: Fetching Docker image: docker.io/renovate/php:7.4.32(branch="renovate/lock-file-maintenance")
DEBUG: Finished fetching Docker image docker.io/renovate/php:7.4.32@sha256:bd14dd1e39900ffd3c68a3df21c08c0f639ee0acb1feba80decc2d252bfe8251(branch="renovate/lock-file-maintenance")

@Ocramius
Copy link
Member

But why would it do that? 😱

@internalsystemerror
Copy link
Member

Perhaps the composer field is confusing it, because from 2.2+ it's supposed to only ignore ext-* and lib-*:

Composer 2.2 and up will be run with --ignore-platform-req='ext-' --ignore-platform-req='lib-', which ignores extension and library platform requirements but not the PHP version itself and should work in most cases.
Older Composer versions will be run with --ignore-platform-reqs, which means that all platform constraints (including the PHP version) will be ignored by default. This can result in updated dependencies that are not compatible with your platform.
https://docs.renovatebot.com/configuration-options/#composerignoreplatformreqs

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 4f6eabd to 47ae424 Compare October 25, 2022 15:52
Signed-off-by: Renovate Bot <bot@renovateapp.com>
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 47ae424 to ca66312 Compare October 25, 2022 15:52
@internalsystemerror
Copy link
Member

#88 Appears to have done the trick \o/

DEBUG: Using php constraint from config(branch="renovate/lock-file-maintenance")
DEBUG: composer command(branch="renovate/lock-file-maintenance")
{
"cmd": "composer",
"args": "update --ignore-platform-req='ext-' --ignore-platform-req='lib-' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins"
}

@Ocramius Ocramius self-assigned this Oct 25, 2022
@Ocramius Ocramius added this to the 3.12.0 milestone Oct 25, 2022
@Ocramius
Copy link
Member

Amazing, thanks @internalsystemerror!

@Ocramius Ocramius merged commit dbdab52 into 3.12.x Oct 25, 2022
@Ocramius Ocramius deleted the renovate/lock-file-maintenance branch October 25, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants