Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_rewrite funkiness #78

Open
mezzoblue opened this issue Dec 6, 2013 · 5 comments
Open

mod_rewrite funkiness #78

mezzoblue opened this issue Dec 6, 2013 · 5 comments

Comments

@mezzoblue
Copy link
Owner

After publishing the new mod_rewrite rules a few previously unnoticed issues have come up.

  • External CSS files have always been permitted for the sake of previewing and testing. They no longer work:

http://www.csszengarden.com/?cssfile=http://www.skybased.com/css-zen-garden/css/screen.css

  • This could be partially addressed by solving the above, but seems like it still might be a separate issue. Designs that rely on the older markup are meant to still be supported with the addition of /legacy/ in the URL. They now break in a slightly different way:

http://csszengarden.com/legacy/?cssfile=http://www.brucelawson.co.uk/zen/sample.css/

@eyesofjeremy
Copy link
Contributor

Good to know. Also, an older-style URL (http://www.csszengarden.com/?cssfile=/216/216.css) resolves incorrectly to http://www.csszengarden.com/216// (note the second slash). My guess is this issue is unrelated, but at any rate, it's all in voodoo-land.

I will have to get my repo up to date before I can take a look. If you see anything else, I'll be tracking this issue. Or 'watching' it... you know.

@mezzoblue
Copy link
Owner Author

Also the 'View This Design's CSS File' link is broken. Links to http://csszengarden.com/218/218/ instead of http://csszengarden.com/218/218.css, for example.

@eyesofjeremy
Copy link
Contributor

I don't have access to my full repo yet. But looking at the code, I think fixing the 'View This Design's CSS File' link is a very small matter. I've submitted 'patch-1', but I haven't been able to test it yet.

@mezzoblue
Copy link
Owner Author

'View Design's CSS File' link issue fixed, the other two remain.

eyesofjeremy added a commit to eyesofjeremy/csszengarden.com that referenced this issue Apr 16, 2014
eyesofjeremy added a commit to eyesofjeremy/csszengarden.com that referenced this issue Apr 16, 2014
@mezzoblue
Copy link
Owner Author

We're doing pretty well with this, the main remaining issue is getting legacy CSS files linking properly, a la #88 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants