GRIDBOT-7: Incorrect expiration dates on screenshot utility #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-petko
deleted the
fix/incorrect-instance-expiration-screenshot-utility
branch
nikita-petko
restored the
fix/incorrect-instance-expiration-screenshot-utility
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue that doesn't break anything, but is quite annoying; when executing a view-console on a grid server, the "time to expire" is incorrect, and behind the current time even.
Example:
[Message sent at 17:24, instance created at 17:24, default lease is 15 minutes]
There is a possible reasoning behind this being the following:
The RenewLease() method is called inside GridServerInstance.Unlock(), which is called after code is executed.
This part here is possibly assigning the _expiration field to an incorrect value giving us the massively offset values.
On the branch fix/incorrect-instance-expiration-screenshot-utility, {{}} we are going to work on a fix by removing this section to determine if it is actually this part that is causing it.