Removing need for ReorientTetMesh [no-tet-reorder-dev] #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # linalg/strumpack.cpp # linalg/strumpack.hpp
tzanio
reviewed
Aug 19, 2021
tzanio
reviewed
Aug 19, 2021
tzanio
reviewed
Aug 19, 2021
tzanio
reviewed
Aug 19, 2021
tzanio
reviewed
Aug 19, 2021
tzanio
reviewed
Aug 19, 2021
tzanio
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Approved modulus some small review comments.
Thanks for this impressive effort @mlstowell... it has been long time in the making!
🎉 🎉 🎉
|
Re-merged in |
This was referenced Aug 26, 2021
Closed
3 tasks
62 tasks
61 tasks
tzanio
added a commit
that referenced
this pull request
Jul 9, 2023
Fix missing `bdr_elem_fos` from #1046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
DofTransformationclass which performs a linear mapping of degrees of freedom on triangular faces to enable Nedelec basis functions to align properly regardless of the relative orientation of the elements.With the addition of
DofTransformation, the methods[Par]Mesh::ReorientTetMeshare no longer needed. This PR currently comments out these methods rather than removing them. Unless someone makes an argument for keeping them in the library I think we should remove these methods before merging this PR.The
test_eigs.cppandtest_eigs_nd.cppprograms were used to validate the new DoF ordering scheme for all triangle face orientations at a variety of basis function orders. These programs don't need to be part of this PR but they may be useful as part of the test suite. Edit: a version oftest_eigs.cpphas been added as a unit test intests/unit/fem/test_eigs.cpp.The
ex_nd_amr_p.cppprogram can be used to test the new code in an AMR context. This code implements an exact solution which is only valid on square or cube-shaped domains. It can be run on any 2D or 3D mesh but the solution errors will only be correct on squares or cubes.This PR has the potential to interfere with any code that uses high order Nedelec basis functions on tetrahedral meshes. Unfortunately, we don't have that many relevant test cases in our examples/miniapps/unit tests. I've invested a lot of time testing this branch with the unit tests, autotest, and custom examples but I know there are pieces of code that have not been covered by these tests. I would really appreciate it if the reviewers could test this code further if they know of any suitable test cases.