Documentation for PA #50
Conversation
First draft based on the libCEED documentation
Move the radio button for PA from "Applications" to "Discretization". Also, fix the listing for ex20 and make the options for showing Laghos more specific.
|
@barker29 and @mlstowell, can you please take a look? |
src/partial-assembly.md
Outdated
| operator can be applied on the faces. An analogous **D<sub>F</sub>** operator | ||
| is then applied at the face quadrature points. | ||
|
|
||
| Currently, we support partial assembly only for Gauss-Lobatto and Bernstein |
There was a problem hiding this comment.
I think there should be a the in for the Gauss...
There was a problem hiding this comment.
Overall, I think it looks very good. One thing I'd like to see added is an explicit statement regarding triangles, tetrahedra, etc.. Support for Quads and Hexes are mentioned a couple times but we should be clear about the current state and/or plans for support of other element types. There's no need to go into great detail.
src/partial-assembly.md
Outdated
| is then applied at the face quadrature points. | ||
|
|
||
| Currently, we support partial assembly only for Gauss-Lobatto and Bernstein | ||
| bases, with integrators that don't require derivatives on the faces. |
There was a problem hiding this comment.
To be a bit more precise: "derivatives" -> "normal derivatives".
There was a problem hiding this comment.
Well, to be completely accurate, we don't support tangential derivatives, but we could support them easily, contrary to normal derivatives that require a bit of work.
There was a problem hiding this comment.
Yes, you are right. I thought you added the tangential derivatives. Anyway, the code for computing them is already there, in FaceQuadratureInterpolator, so it is just a matter of storing them if they are requested. The normal derivatives, on the other hand, will require different face-restriction and different face-quadrature-interpolator.
src/partial-assembly.md
Outdated
| and reference geometry. Currently, only fixed order and geometry is supported, | ||
| meaning that all the blocks of **B** are identical. |
There was a problem hiding this comment.
| and reference geometry. Currently, only fixed order and geometry is supported, | |
| meaning that all the blocks of **B** are identical. | |
| and reference geometry. In the common case where the mesh has fixed polynomial order | |
| and only one element type, then all the blocks of **B** are identical. |
There was a problem hiding this comment.
Should we not also mention that this common case is the only one that is currently supported (natively) in MFEM?
There was a problem hiding this comment.
I was hoping to leave the documentation generic, so that it still applies if this capability is added, but that's probably overly lazy and you're right that we should mention this.
Co-authored-by: Andrew T. Barker <barker29@llnl.gov>
|
@dylan-copeland do you want to mention the H(div) PA support in Examples 4 and 5 here? |
There was a problem hiding this comment.
I made same small adjustments, but overall this looks great.
Thank you @YohannDudouit, @pazner, @barker29, @mlstowell!
This PR adds documentation for Partial Assembly on the MFEM web page (based on the libCEED documentation).
The options on the examples page have been modified slightly, replacing "High-performance" with "Partial assembly" (and listing this option as a discretization option rather than application). Some other minor organizational tweaks to the example page were also made.
Note that this documentation makes reference to the multigrid PR (mfem/mfem/pull/1097), which is currently in
nextand seems likely to be merged soon. Therefore, this PR should be merged only after #49.Closes #41.