Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounding shape image saving feature #100

Merged
merged 5 commits into from
Nov 4, 2023

Conversation

mfl28
Copy link
Owner

@mfl28 mfl28 commented Nov 1, 2023

  • Adds feature that allows to save bounding-shape cropped regions of images to disk (as png image files - masked-out parts of an image are transparent).
  • Saving is triggered via the new Save as Image... bounding shape context-menu item (opens a file-chooser).
  • Fixes an issue with key-releases not being triggered correctly.
  • Updates and extends unit tests.

Closes #98.
Fixes #99.
Fixes #101 .

@mfl28 mfl28 self-assigned this Nov 1, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (ce3a8f9) 86.26% compared to head (4f46b86) 86.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     86.26%   86.37%   +0.11%     
- Complexity     1437     1462      +25     
============================================
  Files            92       92              
  Lines          5789     5880      +91     
  Branches        524      538      +14     
============================================
+ Hits           4994     5079      +85     
+ Misses          539      536       -3     
- Partials        256      265       +9     
Files Coverage Δ
...l28/boundingboxeditor/ui/EditorsSplitPaneView.java 98.34% <100.00%> (+0.21%) ⬆️
...28/boundingboxeditor/ui/ImageFileExplorerView.java 100.00% <100.00%> (ø)
.../mfl28/boundingboxeditor/ui/TagScrollPaneView.java 98.85% <100.00%> (+0.11%) ⬆️
...om/github/mfl28/boundingboxeditor/ui/MainView.java 83.52% <71.42%> (+0.32%) ⬆️
...mfl28/boundingboxeditor/controller/Controller.java 78.41% <74.07%> (-0.55%) ⬇️
...28/boundingboxeditor/ui/ObjectTreeElementCell.java 95.43% <75.75%> (+0.21%) ⬆️
...8/boundingboxeditor/ui/WorkspaceSplitPaneView.java 81.90% <77.04%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.2% 80.2% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit 10520bc into master Nov 4, 2023
10 checks passed
@mfl28 mfl28 deleted the feature/add-bounding-shape-image-saving branch November 4, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant