Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation key release handler incorrectly consumes non-navigation key release events #99

Closed
mfl28 opened this issue Nov 1, 2023 · 0 comments · Fixed by #100
Closed

Navigation key release handler incorrectly consumes non-navigation key release events #99

mfl28 opened this issue Nov 1, 2023 · 0 comments · Fixed by #100
Assignees
@mfl28
Labels
bug Something isn't working

Comments

@mfl28
Copy link
Owner

mfl28 commented Nov 1, 2023

Describe the bug
Navigation key release handler incorrectly consumes non-navigation key release events. This results in corresponding actions not being triggered (after first successful trigger).

To Reproduce
Steps to reproduce the behavior:

  1. Load image, enter category, draw bounding box.
  2. Select bounding box and hit Delete -> the box is deleted.
  3. Draw another box, select it, hit Delete -> deletion is not triggered.

Expected behavior
All actions should trigger correctly.

Desktop (please complete the following information):

  • OS: All
@mfl28 mfl28 added the bug Something isn't working label Nov 1, 2023
@mfl28 mfl28 self-assigned this Nov 1, 2023
@mfl28 mfl28 mentioned this issue Nov 1, 2023
Merged
@mfl28 mfl28 closed this as completed in #100 Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfl28 mfl28

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bounding shape image saving feature mfl28/BoundingBoxEditor
1 participant
@mfl28