less obtrusive warning about modules hash

mfncooper · May 21, 2011 · 13b6f33 · 13b6f33
1 parent 2e9e3f8
commit 13b6f33
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lib/utils/read-json.js b/lib/utils/read-json.js
@@ -141,6 +141,7 @@ function jsonParseFail (ex, file, cb) {
   throw e
 }
 
+var modulesWarned = {}
 function processObject (opts, cb) { return function (er, json) {
 
   // slashes would be a security risk.
@@ -215,12 +216,14 @@ function processObject (opts, cb) { return function (er, json) {
     json.keywords = kw
   }
 
+  json._id = json.name+"@"+json.version
+
   var tag = opts.tag
-  if (tag) json.version = tag//+"-"+json.version
+  if (tag) json.version = tag
 
-  if (json.modules) {
-    var e = new Error("modules object is deprecated")
-    log.error(e, "incorrect json: "+json.name)
+  if (json.modules && !modulesWarned[json._id]) {
+    log.warn("modules object is deprecated", json._id)
+    modulesWarned[json._id] = true
     delete json.modules
   }
 
@@ -278,7 +281,6 @@ function processObject (opts, cb) { return function (er, json) {
     })
   }
 
-  json._id = json.name+"@"+json.version
   json = testEngine(json)
   json = parsePeople(unParsePeople(json))
   if ( json.bugs ) json.bugs = parsePerson(unParsePerson(json.bugs))