Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace 'width:100%' with 'marginHorizontal' #80

Closed
wants to merge 4 commits into from
Closed

replace 'width:100%' with 'marginHorizontal' #80

wants to merge 4 commits into from

Commits on Jun 10, 2019

  1. Sometimes we just tell a component its marginHorizontal to calculate … 

    …its width automatically. So I suggest removing "width: 100%" property of line and placeholder. I give a useDefaultWidth property with default value 'true' instead. Now style of line and placeholder become more flexible.
    @ryan-yuan-dev
    ryan-yuan-dev committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    b49166e View commit details
    Browse the repository at this point in the history

  2. Sometimes we just tell a component its marginHorizontal to calculate … 

    …its width automatically. So I suggest removing "width: 100%" property of line and placeholder. I give a useDefaultWidth property with default value 'true' instead. Now style of line and placeholder become more flexible.
    @ryan-yuan-dev
    ryan-yuan-dev committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    c8275fe View commit details
    Browse the repository at this point in the history

  3. replace 'width: 100%' with 'marginHorizontal' to make style of line a… 

    …nd placeholder component more flexible.
    @ryan-yuan-dev
    ryan-yuan-dev committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    657f686 View commit details
    Browse the repository at this point in the history

  4. Using single quotes with ES

    @ryan-yuan-dev
    ryan-yuan-dev committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    2c7326b View commit details
    Browse the repository at this point in the history