Ensure CrateDB process gets terminated on cr8 sigterm #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfussenegger
force-pushed
the
run-crate-sigterm
branch
3 times, most recently
from
cc4cef8
to
6b158e7
Compare
The CrateDB process leaked if `cr8 run-crate` was killed via a SIGTERM.
For example, in a bash script like:
cr8 run-crate latest-nightly &
N1=$!
while ! crash --hosts localhost:4200 -c "select 1" > /dev/null 2>&1; do
sleep 1
done
jps
kill $N1
jps
mfussenegger
force-pushed
the
run-crate-sigterm
branch
from
6b158e7
to
bd05670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.