Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option dap.repl.show_tree: whether to show the tree in REPL #1001

Closed
wants to merge 1 commit into from

Conversation

wookayin
Copy link
Contributor

@wookayin wookayin commented Jul 29, 2023

A new option show_tree can be set by users to configure whether to
show the expandable tree in the DAP REPL window. Concise and simple
representation in the REPL would be useful for many languages,
see #737 for an example (python).

The option can be configured using, for instance:

require('dap.repl').show_tree = false

TODO: Add documentation in doc/dap.txt

A new option `show_tree` can be set by users to configure whether to
show the expandable tree in the DAP REPL window. Concise and simple
representation in the REPL would be useful for many languages,
see mfussenegger#737 for an example (python).

The option can be configured using, for instance:

```
require('dap.repl').show_tree = false
```
@wookayin
Copy link
Contributor Author

@mfussenegger Kindly bumping up and bringing this again to your attention.

@mfussenegger
Copy link
Owner

Thanks for the PR. I think having more options to control how the variables are displayed is something I want to add but this is rather limited and I'm not sure about the UI/UX.

I'll need to give this some more thought but I'm pretty sure it will be different than this, so I'm closing the PR

@wookayin
Copy link
Contributor Author

Hope this or similar features can be implemented soon -- this is so essential for python debugging. I'm happy to discuss and contribute more.

@wookayin
Copy link
Contributor Author

wookayin commented Sep 21, 2023

The reason I chose somewhat limited configuration like this is that nvim-dap doesn't have an universal configuration API, and previously we used to inject user configs into global variables (e.g. https://github.com/mfussenegger/nvim-dap/blob/master/doc/dap.txt#L564-L570, or injecting repl.commands.custtom_commands, etc.) We wouldn't need a UI for configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants