Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not append text each time a widgets is opened #1043

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: do not append text each time a widgets is opened #1043

merged 1 commit into from
Oct 12, 2023

Conversation

TheLeoP
Copy link
Contributor

@TheLeoP TheLeoP commented Sep 27, 2023

Fixes #1042.

This is a really naive approach at solving the problem and I'm not sure if this somehow affects other places in the codebase. Since layer.render is being called without a parameter for lnum and end_ inside each widget, the render function appends the widget content instead of replacing it (wich does happend when the widget ir refresh. I saw that in that call 0 and -1 were being passed as values for lnum and end_, so I tried doing the same here and it worked).

@mfussenegger mfussenegger merged commit 92dc531 into mfussenegger:master Oct 12, 2023
4 checks passed
@mfussenegger
Copy link
Owner

Thanks. I tried it for a bit and seems like there's no unintended side effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling toggle multiple times on a widget causes the new text to get appended instead of replaced
2 participants