This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were struggling with getting the pagemenu to work with bound page item ids.
For example we originally found we needed to use item id's with full paths for the href's in the pagemenu to jump to correct section. We were using route-segment module for routing.
This is what we were trying:
where pageUrl = "/page1"
(and I suppose other routing).
Though it was clicking through, there pagemenu wasn't displaying correctly because of exception when the element id lookup would fail because the id used here has unresolved variables (ie. still had the {{...}} in it)
ie. this code in @ line 10 in pageitems.js:
So this is a solution that enables passing the off the pageUrl prefix that gets value resolved before it is stored as part of the items id.
Example how to use it:
The pageitems directive will update the id's of the elements with the pageUrl prefix.
Maybe there is a better solution, but this worked for us.