pytest_runtest_call: Avoid running every test twice #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calling runtest ourselves, we decorate it, and let pytest's default implementation run our decorated function. This fixes mgaitan#1 which apart from impacting performance can lead to subtle issues when running tests. (In other words, I bumped my head hard. :-)
|
Today I hit a confusing bug in other tests (a caching related unit test ran twice :D)! Would love to get this fix merged in. Thanks! |
|
Yes, I would also love to get this across the finish line. Any plans? |
mgaitan
approved these changes
Mar 11, 2023
|
@mgaitan Could you publish the latest version of the code? |
|
I will do it ASAP, meanwhile installing from the zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling runtest ourselves, we decorate it, and let pytest's
default implementation run our decorated function.
This fixes #1
which apart from impacting performance can lead to subtle issues when
running tests. (In other words, I bumped my head hard. :-)