Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaDoc inner class references issues #518

Closed
mgarin opened this issue Aug 5, 2019 · 1 comment
Closed

JavaDoc inner class references issues #518

mgarin opened this issue Aug 5, 2019 · 1 comment

Comments

@mgarin
Copy link
Owner

mgarin commented Aug 5, 2019

There could be some warnings thrown upon JavaDoc compilation due to JDK8 and earlier having issues with referencing inner class constructors:
https://bugs.openjdk.java.net/browse/JDK-8031625

It have been fixed in JDK9, but WebLaF is still far from it. It is probably worth simply avoiding such references for now to have warning-less compilation.

@mgarin mgarin added this to the JDK related milestone Aug 5, 2019
@mgarin mgarin self-assigned this Aug 5, 2019
mgarin added a commit that referenced this issue Aug 5, 2019
- DockablePaneListener.java - New listener for `WebDockablePane` exclusively
- DockableFrameListener.java - Now only used for `WebDockableFrame`

Styling
- StyleListener.java - Now properly extends `EventListener`

Utilities
- AbstractUnits.java - Moved `String` parsing into `Unit` for clarity

General
- Fixed some incorrect {@link ...} JavaDoc usages [ #518 ]
- Removed {@link ...} references to proprietary classes
- Refactored code of some classes
@mgarin mgarin modified the milestones: JDK related, v1.2.11 Sep 26, 2019
mgarin added a commit that referenced this issue Sep 26, 2019
- Fixed multiple incomplete inner class and/or constructor references
- Fixed some incorrectly used JavaDoc references
@mgarin
Copy link
Owner Author

mgarin commented Sep 26, 2019

I've fixed all JavaDoc references to avoid warnings in the build.

@mgarin mgarin closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant