clean up according to PR comments

mgba-emu · May 23, 2023 · 4481c8e · 4481c8e
1 parent a513645
commit 4481c8e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/core/library.c b/src/core/library.c
@@ -37,6 +37,7 @@ struct mLibrary {
 #define CONSTRAINTS_ROMONLY \
 	"CASE WHEN :useSize THEN roms.size = :size ELSE 1 END AND " \
 	"CASE WHEN :usePlatform THEN roms.platform = :platform ELSE 1 END AND " \
+	"CASE WHEN :useModels THEN roms.models & :models ELSE 1 END AND " \
 	"CASE WHEN :useCrc32 THEN roms.crc32 = :crc32 ELSE 1 END AND " \
 	"CASE WHEN :useInternalCode THEN roms.internalCode = :internalCode ELSE 1 END"
 
@@ -98,7 +99,9 @@ static void _bindConstraints(sqlite3_stmt* statement, const struct mLibraryEntry
 	}
 
 	if (constraints->platformModels != M_LIBRARY_MODEL_UNKNOWN) {
+		useIndex = sqlite3_bind_parameter_index(statement, ":useModels");
 		index = sqlite3_bind_parameter_index(statement, ":models");
+		sqlite3_bind_int(statement, useIndex, 1);
 		sqlite3_bind_int(statement, index, constraints->platformModels);
 	}
 }
@@ -183,8 +186,8 @@ struct mLibrary* mLibraryLoad(const char* path) {
 		goto error;
 	} else if (romsTableVersion < 2) {
 		static const char upgradeRomsTable[] =
-			"  ALTER TABLE roms"
-			"\nADD COLUMN models INTEGER NULL";
+			"   ALTER TABLE roms"
+			"\n ADD COLUMN models INTEGER NULL";
 		if (sqlite3_exec(library->db, upgradeRomsTable, NULL, NULL, NULL)) {
 			goto error;
 		}

diff --git a/src/platform/qt/CMakeLists.txt b/src/platform/qt/CMakeLists.txt
@@ -534,6 +534,6 @@ if(BUILD_SUITE)
 			add_test(platform-qt-${TEST_NAME} test-qt-${TEST_NAME})
 		endforeach()
 	else()
-		message("${QT}Test not found")
+		message(WARNING "${QT}Test not found")
 	endif()
 endif()
diff --git a/src/platform/qt/utils.cpp b/src/platform/qt/utils.cpp
@@ -161,7 +161,7 @@ QString keyName(int key) {
 		return QObject::tr("Menu");
 	default:
 		return QKeySequence(key).toString(QKeySequence::NativeText);
-  }
+	}
 }
 
 void SpanSet::add(int pos) {