Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Issue - Object layer now rendering one row of pixels too low over background #2153

Closed
CliveArdern opened this issue Apr 29, 2021 · 2 comments

Comments

@CliveArdern
Copy link

@CliveArdern CliveArdern commented Apr 29, 2021

Build: 0.9.1
OS: Windows 10 x64
CPU: Ryzen 7 3800X
GPU: RTX 2070 SUPER
Frequency: 100%
Games tested: Golden Sun, Golden Sun: The Lost Age

Steps to Reproduce

  1. In Golden Sun or Golden Sun: The Lost Age, begin any random battle.
  2. Select Fight and observe the bottom UI.

Description:
Several layers appear to be incorrectly rendering one pixel too high or too low. This is most noticeable in the Golden Sun games where the character sprites in the Object layer can be seen overlapping the top row of pixels on the Background 1 layer.
In addition, the top row of pixels appears to be duplicated, rendering to two rows instead of one.

Additional Info:
This issue occurs regardless of renderer or enhancement selections.
This issue is not present in 0.8.4. Other intermediary builds have not been tested.
This may be the same issue as #2149

Image A: Character sprites overlapping the buttons in 0.9.1
image

Image B: No issues present in 0.8.4
image

@endrift
Copy link
Member

@endrift endrift commented Apr 29, 2021

This is possibly fallout from c73ad72.

@endrift
Copy link
Member

@endrift endrift commented Apr 30, 2021

I can confirm that reverting that change does fix this, as well as #2149, without regressing the bug it was designed to fix. Reverting it seems like a good plan until I can change the GBA renderer to range-based.

@endrift endrift closed this in 8416380 May 1, 2021
endrift added a commit that referenced this issue May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants