Windows: Inno setup script #1203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you don't have to switch between IsRelease = yes and no. Instead, you set the CurrentReleaseVersion variable to the number of the latest stable release and Inno will decide if the setup you are about to build is a stable or a development package, so you have to alter the script only once for each release cycle. This is the highest level of automation I can currently imagine.
|
Wow, this looks great! Thanks a lot for taking care of it and for the cmake integration! In my opinion, ready to get merged! |
lotharsm
approved these changes
Oct 3, 2018
|
Rebased and merged outside of the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @lotharsm's installer, which I modified and integrated into CMake.
Replaces #941.