NetBSD build fixes #2366
Merged
NetBSD build fixes #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetBSD has newlocale/snprintf_l but does not have uselocale or per-thread locales.
endrift
reviewed
Nov 28, 2021
| @@ -94,6 +94,8 @@ static inline int ThreadSetName(const char* name) { | |||
| #elif defined(__HAIKU__) | |||
| rename_thread(find_thread(NULL), name); | |||
| return 0; | |||
| #elif defined(__NetBSD__) | |||
| return pthread_setname_np(pthread_self(), "%s", (void *)name); | |||
There was a problem hiding this comment.
Why does this need to be cast to void*? This is C code.
There was a problem hiding this comment.
"error: invalid conversion from ‘const void*’ to ‘void*’ [-fpermissive]"
There was a problem hiding this comment.
Ohh fair enough. Please add a space between the cast and the variable then.
|
Was there really no HAVE flags section yet?? I need to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had these fixes in pkgsrc for well over a year now. Please merge them!
newlocaleandsnprintf_lwithout usinguselocale- NetBSD does not have per-thread locales.popcount32is in libc on NetBSD, don't override its definition.pthread_setname_nptakes a printf format string.