Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

dag menu: make it work with control custom names #62

Closed
miquelcampos opened this issue Sep 14, 2020 · 5 comments
Closed

dag menu: make it work with control custom names #62

miquelcampos opened this issue Sep 14, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@miquelcampos
Copy link
Member

With custom names in controls, the right menu tools will not work.

Also related: anim_utils: get_ik_fk_controls assumes that the component in the guide will have the same name as the component type #61

Probably custom names also affect synoptic and animPicker. Check after close this.

@jdrese I will work on this ticket this week. Please let me know if it is ok with you. :)

@miquelcampos miquelcampos added the bug Something isn't working label Sep 14, 2020
@miquelcampos miquelcampos self-assigned this Sep 14, 2020
@jdrese
Copy link
Member

jdrese commented Sep 14, 2020

@miquelcampos yes no problem for me.

@miquelcampos
Copy link
Member Author

miquelcampos commented Oct 12, 2020

Now is working with custom names in the components using "_" sign. (that was fixed on #61 )
But still not working with custom name rules. Provably we need to implement a message connections system or another type of metadata in order to find the current blend attribute.

@jdrese I am going to leave this bug open as a known issue. And will review it after finishing this project. Any idea is welcome :)
I have moved the ticket to 3.x.x project

@miquelcampos
Copy link
Member Author

@jdrese Changed my mind!
I think I have a solution but will need to add a few changes and test how it will affect other tools.
Also need to keep the old method for back compatibility.

  1. The name of the attribute should be related to the component name, not the component type name. For example, if the arm component is called "brazo" the attributes will be also prefixed with "brazo_" and not "arm_"

  2. add a few attributes from the component build that creates the ik and fk list of controls. So we can feed any name pattern

  • component name + fk_match: i.e: brazo_custom_name_blabla_fk_match
  • component name + ik_match: i.e: brazo_custom_name_blabla_ik_match

This will allow supporting multiple components of the same type on the same UI host

@jdrese
Copy link
Member

jdrese commented Oct 12, 2020

This sounds indeed a better option!

miquelcampos added a commit that referenced this issue Oct 28, 2020
…same blend for ik/match. Need to try with range matching and add support for custom naming templates #62
@miquelcampos
Copy link
Member Author

miquelcampos commented Oct 28, 2020

miquelcampos added a commit that referenced this issue Oct 28, 2020
…ponents, only the first component will baked in range #62
miquelcampos added a commit that referenced this issue Nov 27, 2020
WIP  now the ik/fk switch works with the new message attr connections #62
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants