Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot easily update computed config members in ProjectConfig #823

Closed
tvrtkos opened this issue May 6, 2016 · 6 comments
Closed

Cannot easily update computed config members in ProjectConfig #823

tvrtkos opened this issue May 6, 2016 · 6 comments
Assignees

Comments

@tvrtkos
Copy link

tvrtkos commented May 6, 2016

If you set APP_SRC inside ProjectConfig you don't get .css files injected into index.html.

I guess the reason is that properties like CSS_SRC and APP_ASSETS are calculated using old/default value of APP_SRC.

I can change APP_SRC inside SeedConfig as a workaround.

@mgechev
Copy link
Owner

mgechev commented May 8, 2016

Yes, this is an issue discussed before. I guess a way to handle is by using property accessors instead.

If you have some spare time, a PR is welcome!

@joshwiens
Copy link
Contributor

@mgechev - I'm working on the manual_typings problem, I can roll this into that PR unless @tvrtkos wants to take this one.

If I don't see anything by the time I finish with the typings, i'll fix this in the PR for that

@joshwiens joshwiens self-assigned this May 8, 2016
@Paladinium
Copy link

Same issue as #630

@tvrtkos : you'll see the workaround there which is just overriding all dependent variables.

@ludohenin ludohenin changed the title Cannot change APP_SRC in ProjectConfig Cannot easily update computed config members in ProjectConfig May 21, 2016
@ludohenin
Copy link
Collaborator

@d3viant0ne Are you working on that one, or can I take over ?

@mgechev
Copy link
Owner

mgechev commented May 29, 2016

Any updates here? I can take it as well.

@mgechev
Copy link
Owner

mgechev commented Oct 25, 2016

Duplicate of #1429

@mgechev mgechev closed this as completed Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants