comment-spacings false positives for nolint directives

[abemedia]

Describe the bug
I'm using revive with golangci-lint and since the latest update I'm getting errors like this:

api/common/validate/validate.go:15:1: comment-spacings: no space between comment delimiter and comment text (revive)
//nolint:gochecknoglobals

I've updated the config to contain nolint in the comment-spacings arguments to make it go away but it's odd as this was not happening before.

To Reproduce
Steps to reproduce the behavior:

1. I updated golangci-lint:

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin

2. I run it with the following flags & configuration file:

golangci-lint run

linters:
  disable-all: true
  enable:
    - revive
linters-settings:
  revive:
    rules:
      - name: comment-spacings
        disabled: false

Desktop (please complete the following information):

• OS: Ubuntu 22.04.2 LTS
• go version go1.20.2 linux/amd64

[chavacava]

Hi @abemedia, thanks for filling the issue.

My understanding of the issue is you ask for nolint be part of the default accepted directives (alongside with go and revive). Is my understanding OK? If yes, feel free to make a PR.

[thaJeztah]

I don't think a hard-coded list should be used for these. Comments without a space are meant for "machine-readable" comments (such as //nolint:). Such comments are valid, but must follow the format described in golang/go#37974 (comment)

//[a-z0-9]+:[a-z0-9]

(// (comment), followed by a "namespace" ([a-z0-9]+), a colon (:), and some text ([a-z0-9]. after it)

See;

• go/doc: drop //go:* comments from extracted docs golang/go#37974 (comment)
• doc: add guidelines for comment directives golang/go#43776
• [go1.19] cmd/gofmt: machine-readable (//nolint) comments should not be reformatted golang/go#53835 (comment)

[chavacava]

Il will try to do a PR on this subject in the next days. My idea is to go ahead with the proposition by @thaJeztah (i.e. replacing the hard coded list with a regex)

[thaJeztah]

Thanks! Sorry for commenting with suggestions without doing the actual work; couldn't find the bandwidth to get familiar with the codebase and to make the changes, but very much appreciate the project! (it definitely caught some issues here-and-there in codebases I work on ❤️)