Fix #808 #986
Merged
Fix #808 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, here is what is implemented in gofumpt https://github.com/mvdan/gofumpt/blob/master/format%2Fformat.go#L334 They use a slightly different regexp You can look at historical changes, it gives context |
thaJeztah
reviewed
May 10, 2024
| @@ -165,3 +165,9 @@ func checkNumberOfArguments(expected int, args lint.Arguments, ruleName string) | |||
| panic(fmt.Sprintf("not enough arguments for %s rule, expected %d, got %d. Please check the rule's documentation", ruleName, expected, len(args))) | |||
| } | |||
| } | |||
|
|
|||
| var directiveCommentRE = regexp.MustCompile("//(line |extern |export |[a-z0-9]+:[a-z0-9])") // see https://go-review.googlesource.com/c/website/+/442516/1..2/_content/doc/comment.md#494 | |||
There was a problem hiding this comment.
I wonder if it needs to be anchored (^); I did a quick try using the comment below, and it didn't flag that as invalid;
//this is a regular command that's incorrectly formatted //nolint:foobar // because one two three(disclaimer: I only used the function directly, not in context of the whole code, so perhaps there's already some other code handling this)
There was a problem hiding this comment.
I think you are right, that's why I raised the point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #808 by ignoring comments matching the official pattern for directives