Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue [#59] #70

Merged
merged 1 commit into from
Sep 21, 2018
Merged

fix issue [#59] #70

merged 1 commit into from
Sep 21, 2018

Conversation

chavacava
Copy link
Collaborator

fix candidate for issue #59

@mgechev
Copy link
Owner

mgechev commented Sep 21, 2018

Looks good. I'm slightly concerned that all rules swallow the error returned by TypeCheck. This way, rules using type checking may not report existing linting errors.

We should follow closely how the Go team handles the issue so we can react.

@mgechev mgechev merged commit bd41397 into mgechev:master Sep 21, 2018
@chavacava
Copy link
Collaborator Author

I'm slightly concerned that all rules swallow the error returned by TypeCheck.

Yes, this fix is somewhat brutal in that aspect

We should follow closely how the Go team handles the issue so we can react.

Absolutely! I did not check the go repo to see if there is already an issue related to this problem

@mgechev
Copy link
Owner

mgechev commented Sep 21, 2018

Absolutely! I did not check the go repo to see if there is already an issue related to this problem

I didn't find anything related.

@chavacava chavacava deleted the fix-#59 branch September 30, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants