Fix anchorlinks for logs with low-resolution timestamps #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a counter and append the value of the counter to each anchorlink in the generated HTML output. Timestamps from logs with only minute-resolution will have broken anchorlinks without this fix, because multiple log lines correspond to a single anchorlink when messages were sent during the same minute.
|
Also, this breaks previous anchorlinks. It would be better to add an additional |
|
Another thing I wasn't very happy about was that my anchors were excessively long. Having a counter presents an opportunity to make them shorter. What about using just |
|
I've fixed this in a different way in f8adbe9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs that have many messages in the same minute have broken anchorlinks when the timestamp resolution is minute-level instead of millisecond-level. Here, I use a counter which is appended to each anchorlink.
The unit tests have not been updated yet, so they are presently not passing.
c6855e3