is_abandoned() test: add fence

mgeier · May 26, 2024 · c17b01b · c17b01b
1 parent d995775
commit c17b01b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -139,5 +139,8 @@ jobs:
       - name: Run ThreadSanitizer
         env:
           RUSTFLAGS: "-Z sanitizer=thread"
+        # "no_race_with_is_abandoned" is skipped because ThreadSanitizer
+        # reports false positives when using standalone fences,
+        # see https://github.com/google/sanitizers/issues/1415.
         run: |
-          cargo test --tests -Z build-std --target x86_64-unknown-linux-gnu
+          cargo test --tests -Z build-std --target x86_64-unknown-linux-gnu -- --skip no_race_with_is_abandoned
diff --git a/tests/lib.rs b/tests/lib.rs
@@ -151,6 +151,7 @@ fn no_race_with_is_abandoned() {
         });
         std::thread::yield_now();
         if c.is_abandoned() {
+            std::sync::atomic::fence(std::sync::atomic::Ordering::Acquire);
             unsafe { V = 20 };
         }
         t.join().unwrap();