More __slots__ #374
Merged
More __slots__ #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnovativeInventor
force-pushed
the
more-slots
branch
from
97dd5f6
to
ab7acfa
Compare
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 87.89% 88.20% +0.31%
==========================================
Files 37 37
Lines 1660 1662 +2
==========================================
+ Hits 1459 1466 +7
+ Misses 201 196 -5
Continue to review full report at Codecov.
|
InnovativeInventor
force-pushed
the
more-slots
branch
from
ab7acfa
to
9c5265e
Compare
|
@apizzimenti I just rebased this off |
pizzimathy
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
These changes match the design patterns from #363 and improve performance. Seems like a good addition to the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR broken out from #372 to ease the code review process.
In particular, this patch adds the
__slots__method to a few classes that are created often, which improves memory and runtime performance (marginally but measurably). In theory, this is a breaking change, as users will no longer be able to add arbitrary attributes to theAssignmentandSubgraphViewclass. However, I don't think this is something that people do (it would be quite strange, no?).This PR inspired by @pjrule #363. See that PR for more details on the reasoning.