Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out Assignment.update (replace with Assignment.update_flows) to prevent double-calculating flows #383

Merged
merged 1 commit into from Feb 10, 2022

Conversation

InnovativeInventor
Copy link
Member

@InnovativeInventor InnovativeInventor commented Jan 19, 2022

This is a PR broken out from #372 to ease the code review process -- this is the second batch of PRs, after which that perf-tuning branch will be considered fully merged in.

@codecov-commenter
Copy link

Codecov Report

Merging #383 (572ed0e) into main (8acd44c) will decrease coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   88.17%   88.16%   -0.02%     
==========================================
  Files          37       37              
  Lines        1666     1664       -2     
==========================================
- Hits         1469     1467       -2     
  Misses        197      197              
Impacted Files Coverage Δ
gerrychain/grid.py 73.49% <0.00%> (ø)
gerrychain/proposals/tree_proposals.py 27.27% <50.00%> (ø)
gerrychain/constraints/contiguity.py 96.59% <100.00%> (ø)
gerrychain/metagraph.py 94.44% <100.00%> (ø)
gerrychain/partition/assignment.py 95.89% <100.00%> (-0.11%) ⬇️
gerrychain/partition/partition.py 98.76% <100.00%> (ø)
gerrychain/proposals/proposals.py 97.67% <100.00%> (ø)
gerrychain/proposals/spectral_proposals.py 87.50% <100.00%> (ø)
gerrychain/updaters/compactness.py 97.72% <100.00%> (ø)
gerrychain/updaters/county_splits.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acd44c...572ed0e. Read the comment docs.

Copy link
Contributor

@gabeschoenbach gabeschoenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gabeschoenbach gabeschoenbach merged commit 61ca3f3 into main Feb 10, 2022
@InnovativeInventor InnovativeInventor deleted the perf-assignment-flows-opt branch May 24, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants