Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default updaters bug in GeographicPartition #391

Merged
merged 2 commits into from Apr 14, 2022

Conversation

InnovativeInventor
Copy link
Member

Several GerryChain users have been reporting a bug in the most recent version of GerryChain where the default updaters in a GeographicPartition (e.g. area, boundary_nodes, etc.) are not being instantiated properly. This PR fixes the bug and adds regression tests to ensure that this doesn't happen again.

It also renames the use_cut_edges flag to use_default_updaters, which more accurately reflects its intended purpose.

@codecov-commenter
Copy link

Codecov Report

Merging #391 (2638415) into main (005d77a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   87.83%   87.84%           
=======================================
  Files          37       37           
  Lines        1735     1736    +1     
=======================================
+ Hits         1524     1525    +1     
  Misses        211      211           
Impacted Files Coverage Δ
gerrychain/partition/partition.py 92.30% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005d77a...2638415. Read the comment docs.

Copy link
Contributor

@gabeschoenbach gabeschoenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gabeschoenbach gabeschoenbach merged commit 18cde80 into main Apr 14, 2022
@InnovativeInventor InnovativeInventor deleted the fix-default-updaters-bug branch May 24, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants