Port GerryChain adjacency calcs to Shapely 2.0 #405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shapely 2.0 will introduce breaking changes for GerryChain. In particular, our adjacency calculation code will break (and we won't be able to make new dual graphs). Although Shapely 2.0 hasn't stabilized yet, it appears that recent updates in our dependencies (i.e. geopandas) has caused some issues to show up prior to Shapely 2.0 being offically stable.
Relevant issues:
maup
for adjacencies? #287#369 was originally a stop-gap fix for this PR. We should be able to remove the import warning in
gerrychain/__init__.py
.