Unsafe usage of new static() errors

[davereid]

How is drupal-check installed?

• drupal-check is installed using the phar
• drupal-check is installed globally via Composer
• drupal-check is installed globally using consolidation/cgr
• drupal-check is installed as a dependency to my project

Environment:

• OS: Linux
• PHP Version: 7.3
• Drupal core: 8.8.x

Describe the bug
Getting errors with standard Drupal plugin code which implements the \Drupal\Core\DependencyInjection\ContainerInjectionInterface::create() method:

Unsafe usage of new static().
         💡 Consider making the class or the constructor final.

The code is usually implemented in the following way:

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('entity_type.manager')
    );
  }

Should this error be excluded from drupal-check runs? Changing all of our code to use new self instead of new static means we have a lot of replacement to do, and fixing a lot of core code...

Console output
vendor/bin/drupal-check -a web/modules/custom

[davereid]

For reference: phpstan/phpstan#2773

[Sergey-Orlov]

Any clues how to avoid these errors?

[fgm]

No idea how phpstan works, but if it was hookable, the extension could check whether this is either a ContainerInjectionInterface or ContainerFactoryPluginInterface, and pass the check in that case; which should cover most such cases.

[Dropa]

Following this, since as far as I know, new static is intentional solution. Changing it to new self would mean that every child class would have to override create() function, which in some cases, such as plugins would be huge pain in the arse.

While I agree with @fgm I don't think there is no other function than create() where new static would need to be allowed

[mglaman]

We need to alter the ignoreErrors value. This causes too many problems in Drupal were we always use new static instead of self.

[MPParsley]

Note that the failing tests hid this error:

 -- -------------------------------------------------------------------------- 
     Error                                                                     
 -- -------------------------------------------------------------------------- 
     Ignored error #Unsafe usage of new static()# has an unescaped '()' which  
     leads to ignoring all errors. Use '\(\)' instead.                         
 -- -------------------------------------------------------------------------- 

I opened a PR to fix this in #191.