Problem with new static unsafe usage

[mitelg]

Support question

Following example given: https://phpstan.org/r/dec561c6-72a9-434b-9a6d-2032b3b13ae3 (simplified!)
Or have a look here: https://github.com/shopware/platform/blob/master/src/Core/Framework/DataAbstractionLayer/Search/EntitySearchResult.php
https://github.com/shopware/platform/blob/master/src/Core/Framework/Struct/Collection.php

PHPStan complains about "Unsafe usage of new static()" in the Collection on line 157

I don't really have an idea, how to fix that. I can't make the class final as many other classes extend from Collection. Also I could not make the constructor final as e.g. the EntitySearchResult is using more constructor parameter.

Wish you all happy holidays! 🎄 🎆

[adaamz]

Use new self in each implementation.

[mitelg]

so you mean implementing \Shopware\Core\Framework\Struct\Collection::createNew in each class which extends from it?

[ondrejmirtes]

Yes, ideally make abstract protected function createNew in abstract class Collection.

[mitelg]

puh, that are going to be maaany classes which need a refactoring then...
Is there no other way?

[ondrejmirtes]

You can acknowledge your code has this issue and isn’t typesafe and just ignore this message.

[mitelg]

yes, I will go with this for now. thanks a lot for your help 👍
keep up the good work! 😊 ✌️

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.