Rubocop #116
Merged
Rubocop #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test rubocop as well as the most recent versions of ruby.
|
Seems like there is some sort of parse error with travis, the last test's gemfile is all of them somehow |
Closed
Signed-off-by: Florian Wininger <fw.centrale@gmail.com>
|
Thank you @packrat386 ! 馃憤 for this pull request |
|
馃憤 for the last commit @packrat386 |
| include: | ||
| - rvm: 2.3.1 | ||
| gemfile: gemfiles/rails_5.gemfile | ||
| env: TEST_SUTE=rubocop |
There was a problem hiding this comment.
looks like a typo here. TEST_SUITE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃挌
There's a
.rubocop.ymlin the repo, but it's not a test dependency and the current code is violating it. This fixes the current violations (most of which were auto-correctable) and adds rubocop as a required test on travis. Also adds tests for Rails 5.Thanks to @fwininger for the help.