Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid alias_method_chain #118

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Conversation

mlarraz
Copy link
Contributor

@mlarraz mlarraz commented Jul 19, 2016

This is deprecated as of Rails 5 (in favor of Module#prepend, which is only in Ruby 2+).

Since we still have to support Ruby 1.8, just create the aliases manually

This is deprecated as of Rails 5 (in favor of Module#prepend, which is only in Ruby 2+).

Since we still have to support Ruby 1.8, just create the aliases manually
@fwininger
Copy link
Collaborator

Thank you so much ! I work yesterday on the same commit, but don't have time to do the pull request ! Please @kjg, can you merge it.

@awendt
Copy link
Collaborator

awendt commented Jul 19, 2016

I'd like to question our support for Ruby 1.8 once again, its support ended loooong time ago. People shouldn't be using it in production anymore.

@kjg What do you think?

@fwininger
Copy link
Collaborator

I agree with you. I think we can drop the support of ruby-1.8, ruby-1.9 to use more ruby synthax. Moreover, we can also drop the support of rails 2 and 3, to focus on rails 4 and 5.

@kjg
Copy link
Collaborator

kjg commented Jul 19, 2016

I'll pull this in as well as #116 and make a new release, and then we can create a 2.x branch and then drop support for ruby 1.8 and older rails on the master branch. How does that sound?

@packrat386
Copy link
Contributor

If y'all are going to do that, you should make sure to include a restraint in the gemspec for certain versions of ruby. Also, although 2.0 came out relatively recently, it might be good to leave 2.x supporting what it currently supports and then have 3.0 drop support for some older frameworks.

@kjg kjg merged commit 3a51d47 into mgomes:master Jul 19, 2016
@mlarraz mlarraz deleted the avoid_alias_method_chain branch July 19, 2016 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants